Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible pinning of packaging dependency with >= #97

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

spwoodcock
Copy link
Contributor

Follow on from #93
Related to #95

  • Devs installing this package should have the flexibility to pin as they need.
  • We can't predict if a future version of packaging will have breaking changes, so shouldn't be restrictive with approximate pinning.
  • I also downgraded the minimum version of packaging back to v23.1, which was working fine prior to the upgrade in fix(deps): update dependency packaging to v24 #95.
  • That version was released around a year and a half ago, which should give plenty of flexibility for a minimum.

devs downstream should have the flexibility to pin as they need. We can't predict if a future version of `packaging` will have breaking changes, so shouldn't be restrictive
@dimastbk dimastbk merged commit c6e7a81 into dimastbk:master Nov 7, 2024
29 checks passed
@spwoodcock spwoodcock deleted the patch-2 branch November 7, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants